Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature + Backend: Prevent command early execution #3377

Open
wants to merge 9 commits into
base: beta
Choose a base branch
from
Open

Feature + Backend: Prevent command early execution #3377

wants to merge 9 commits into from
+111 −0

Conversation

KeinsWolfi
Copy link
Contributor

@KeinsWolfi KeinsWolfi commented Feb 6, 2025 •
edited
Loading

What

Prevents the user from executing a command too early by executing said command after said cooldown is over.

Changelog New Features

  • Added command early execution stop. - Helium9

Changelog Technical Details

  • Added primitive CommandSentEvent. - Helium9

@KeinsWolfi
Copy link
Contributor Author

TODO: Config

@github-actions github-actions bot added the Detekt Has detekt problem label Feb 6, 2025
@github-actions github-actions bot removed the Detekt Has detekt problem label Feb 6, 2025
@KeinsWolfi
Copy link
Contributor Author

Wanna do A bit more testing but if you want to review already ill put it on ready for review

@KeinsWolfi KeinsWolfi marked this pull request as ready for review February 6, 2025 17:55
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Feb 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

I have detected some issues with your pull request:

Body issues:
Author is not set in text: + Prevent command early execution. -Helium9
Change should end with a full stop in text: Prevent command early execution. -Helium9
Unexpected empty line after category declared

Title issues:
PR has category 'Feature' which is not in the changelog. Expected categories: Backend

Please fix these issues. For the correct format, refer to the pull request template.

@KeinsWolfi KeinsWolfi changed the title Feature: Prevent command early execution Feature + Backend: Prevent command early execution Feb 6, 2025
@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Feb 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

I have detected some issues with your pull request:

Body issues:
Author is not set in text: + Added command early execution stop. -Helium9
Change should end with a full stop in text: Added command early execution stop. -Helium9
Unexpected empty line after category declared

Title issues:
PR has category 'Feature' which is not in the changelog. Expected categories: Backend

Please fix these issues. For the correct format, refer to the pull request template.

@hannibal002 hannibal002 added this to the 4.0.0 milestone Feb 6, 2025
@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backend A backend pull request that will be merged soon
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@KeinsWolfi @hannibal002